RFR: 8372942: AArch64: Set JVM flags for Neoverse V3AE core [v2]
Andrew Haley
aph at openjdk.org
Wed Feb 4 12:17:26 UTC 2026
On Wed, 4 Feb 2026 11:41:40 GMT, Ruben <duke at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/vm_version_aarch64.hpp line 33:
>>
>>> 31: #include "utilities/sizes.hpp"
>>> 32:
>>> 33: #include <initializer_list>
>>
>> I'm not sure you can do this. In [the guide](https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md) you'll see _Only curated parts of the C++ Standard Library may be used by HotSpot code_ and _Most HotSpot code should not directly #include C++ Standard Library headers..._ A parameter pack would be fine here instead of `initializer_list`.
>
> Thanks for the additional feedback.
>
> Since this PR has been merged, I can prepare a follow-up PR to address this specific issue if that is suitable.
> If you would prefer, I can instead open a backout PR and then propose a refined version of the original patch.
>
> Please let me know which approach you would like me to take.
Let's be quiet for now. it's not worth changing it. We can review it later if it arises as an issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28607#discussion_r2763710261
More information about the hotspot-dev
mailing list