RFR: 8377446: Improve parameter naming in pointer_delta()

Christian Hagedorn chagedorn at openjdk.org
Tue Feb 10 08:27:29 UTC 2026


On Mon, 9 Feb 2026 08:41:36 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this renaming of arguments to `pointer_delta`, instead of `left` and `right` use `high` and `low` (address) to (imo) better indicate the expected meaning of the arguments.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

Looks good to me, thanks for cleaning these up!

src/hotspot/share/adlc/adlArena.cpp line 139:

> 137: 
> 138: //------------------------------realloc----------------------------------------
> 139: static size_t pointer_delta(const void *high, const void *low) {

While at it:

Suggestion:

static size_t pointer_delta(const void* high, const void* low) {

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29631#pullrequestreview-3777416127
PR Review Comment: https://git.openjdk.org/jdk/pull/29631#discussion_r2786482697


More information about the hotspot-dev mailing list