RFR: 8377172: Change datatype of CodeEntryAlignment to uint [v3]
Manuel Hässig
mhaessig at openjdk.org
Tue Feb 10 14:03:40 UTC 2026
On Tue, 10 Feb 2026 13:39:31 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> The main idea of this change is to remove an implicitly narrowing conversion to int from intx (`int code_alignment()`).
>>
>> CodeEntryAlignment is constrained to not be bigger than CodeCacheSegmentSize that is itself constrained to be in the range(1, 1024). The data type should really be a uint16_t as its allowed range is [16-1024], but we have no such support for VM flags. uint will do, and will simplify the code greatly (five less casts, six if we count the implicit narrowing cast).
>>
>> This change is inspired by my change 8376892: Allow conversion warnings in subsets of the code base.
>>
>> Completed test tier 1-3.
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>
> fix format specifyers to unsigned
Thanks for addressing my comments. I just noticed that the copyright years also need updating. I can recommend `bin/update_copyright_year.sh` for this amount of files.
-------------
Changes requested by mhaessig (Committer).
PR Review: https://git.openjdk.org/jdk/pull/29637#pullrequestreview-3779147926
More information about the hotspot-dev
mailing list