RFR: 8377658: G1: Cleanup g1ConcurrentMark.cpp for stricter warning flags
Leo Korinth
lkorinth at openjdk.org
Fri Feb 13 11:00:12 UTC 2026
On Fri, 13 Feb 2026 10:56:10 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> src/hotspot/share/gc/z/zBitField.hpp line 77:
>>
>>> 75: static ContainerType encode(ValueType value) {
>>> 76: assert(((ContainerType)value & (FieldMask << ValueShift)) == (ContainerType)value, "Invalid value");
>>> 77: return (ContainerType)(((ContainerType)value >> ValueShift) << FieldShift);
>>
>> This change should not be done in a PR that sounds like it is only fixing G1. It needs its own PR with an explanation why it is needed.
>
> It is only fixing g1, unfortunately `barrierSetConfig.inline.hpp` does include zgc headers.
I thought it was harmless enough to be passed as a g1 fix, I even kept the c style cast.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29701#discussion_r2803621451
More information about the hotspot-dev
mailing list