RFR: 8377658: G1: Cleanup g1ConcurrentMark.cpp for stricter warning flags

Stefan Karlsson stefank at openjdk.org
Fri Feb 13 11:18:12 UTC 2026


On Fri, 13 Feb 2026 11:04:07 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> I thought it was harmless enough to be passed as a g1 fix, I even kept the c style cast.
>
> Do you think I should open an enhancement for the barrierSetConfig.inline.hpp issue?

Even though the goal is to make a G1 cpp file compile cleanly with this warning, you need to make changes to header files for various subsystems of HotSpot. I think that there should be separate PRs for the various sub-systems, or the PR needs to be named in a way that those sub-system maintainers notice them. There should also be a clear explanation for each non-obvious change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29701#discussion_r2803670359


More information about the hotspot-dev mailing list