RFR: 8377507: Store cpu features in AOTCodeCache [v5]
Ashutosh Mehra
asmehra at openjdk.org
Tue Feb 17 14:52:53 UTC 2026
On Tue, 17 Feb 2026 08:37:21 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix bug in aarch64 implementation
>>
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Looks ok modulo the question about printing extra cpu features.
@adinn can you please review it again.
> src/hotspot/share/code/aotCodeCache.cpp line 458:
>
>> 456: VM_Version::store_cpu_features(runtime_cpu_features);
>> 457: VM_Version::get_missing_features_name(runtime_cpu_features, cached_cpu_features_buffer, ss);
>> 458: log.print_cr("Additional runtime CPU features: %s", ss.as_string());
>
> Should we omit this when there are no extra features? i.e. the cached and runtime feature set is identical?
Good point. I updated it to print the message when not empty.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29655#issuecomment-3915149896
PR Review Comment: https://git.openjdk.org/jdk/pull/29655#discussion_r2817434393
More information about the hotspot-dev
mailing list