RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v4]
María Arias de Reyna Domínguez
duke at openjdk.org
Wed Feb 18 09:11:28 UTC 2026
On Wed, 18 Feb 2026 07:21:59 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> María Arias de Reyna Domínguez has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Adding index on CPPool for better tracking
>> - Adding explanation for indy and fields
>
> src/hotspot/share/oops/cpCache.cpp line 460:
>
>> 458: klass_name->as_C_string(), name->as_C_string(), signature->as_C_string(),
>> 459: rfi->is_resolved(Bytecodes::_getstatic) || rfi->is_resolved(Bytecodes::_putstatic) ? " *** static" : "");
>> 460: if (!archived && !CDSConfig::is_dumping_preimage_static_archive()) {
>
> Why are you checking for `!CDSConfig::is_dumping_preimage_static_archive()`?
Because it was one of the conditionals on the previous if. If I only check if it is archived, it could be this message is printed when it shouldn't have been archived. I think.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29690#discussion_r2821178978
More information about the hotspot-dev
mailing list