RFR: 8375359: Improve GC serviceability init staging [v2]
Albert Mingkun Yang
ayang at openjdk.org
Wed Feb 18 17:36:55 UTC 2026
On Wed, 18 Feb 2026 15:16:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> As per docs, `CollectedHeap::post_initialize` is for doing inits that should be done before general allocations are accepted. Currently, serviceability layer initialized there via the call to `CollectedHeap::initialize_serviceability`. This bug shows that after `CollectedHeap::post_initialize` returns, the rest of the serviceability layer had not been fully initialized yet. But GC code might assume general allocation path works at that point! So if that allocation path reports anything to the serviceability layer, it could encounter not yet fully initialized serviceability support and fail.
>>
>> This readily manifests in improved Epsilon stress test. Improved test fails pretty consistently on my machines, and serves as a good regression test.
>>
>> So the fix is to peel off serviceability initialization from post-init stage, and do it separately, before going (and finishing) `post_initialize`. Conveniently, we are nearly there, and "just" need to touch up a few things in `universe_post_init()`.
>>
>> Additional testing:
>> - [x] Linux x86_64 server fastdebug, `gc/epsilon/TestInitAllocs.java`, 10x
>> - [x] Linux x86_64 server fastdebug, `hotspot_gc`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Even cleaner init sequence
> - Merge branch 'master' into JDK-8375359-epsilon-load-race
> - Fix
> - Stress test
Marked as reviewed by ayang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/29254#pullrequestreview-3821288185
More information about the hotspot-dev
mailing list