RFR: 8377895: Create sizeof_auto, to reduce narrowing conversions [v7]
Dean Long
dlong at openjdk.org
Fri Feb 20 05:10:00 UTC 2026
On Thu, 19 Feb 2026 22:29:41 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> `sizeof_auto` is created so that we can reduce the amount of casting and thus make the code more type safe. The normal `sizeof` will return a `size_t` although the size of most stuff can be represented in a `uint8_t`. `sizeof_auto` will return the size in an as small unsigned type as is possible. The result is that expressions that uses `sizeof_auto` can convert to most integral types, and no explicit narrowing cast will be needed.
>>
>> The change in `cpCache.hpp` is an example where we would get an implicit narrowing warning (if we had those enabled) using normal `sizeof`, but where `sizeof_auto` will not make the expression a `size_t` .
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>
> Line break comments, and add compiler error code on Windows to comment
src/hotspot/share/utilities/globalDefinitions.hpp line 179:
> 177: std::conditional_t<N <= std::numeric_limits<uint32_t>::max(), uint32_t, uint64_t>>>;
> 178: return static_cast<unsigned_auto>(N);
> 179: }
This function doesn't really have anything to do with sizeof, does it? Well, except that it is unsigned. This could be named something like smallest_type_for_constant, narrow_const, etc. It is conceivable that in the future we might want something like this for signed values as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29716#discussion_r2831405208
More information about the hotspot-dev
mailing list