RFR: 8370044: TraceBytecodes shouldn't break up lines [v2]
Johan Sjölen
jsjolen at openjdk.org
Sat Feb 21 00:00:19 UTC 2026
On Fri, 20 Feb 2026 13:27:24 GMT, Paul Hübner <phubner at openjdk.org> wrote:
> > > Seems fine, but a few comments.
> > > I don't know if `DEBUG` variable is necessary, maybe always print the debug lines? It's not a lot of output.
> >
> >
> > It's about 2-4 million lines depending on the run, that I'd rather not waste resources on, given jtreg will likely truncate (the middle) anyway. If you feel strongly about it, I can print it anyway.
>
> Sorry I misread this. You're right, it should not be too many lines since it doesn't trace every bytecode. But I've also seen existing tests use a debug variable to fine-grain output. Would you prefer to print it anyway?
>
> I've addressed the rest of your comments and I'm re-running tests, thank you for the feedback.
Up to you, I'm OK with your judgement :-). If it's not a lot of logs, maybe it's nice if the test breaks?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29842#issuecomment-3937694883
More information about the hotspot-dev
mailing list