RFR: 8378298: Remove obsolete CDS string tests
Ioi Lam
iklam at openjdk.org
Sat Feb 21 02:55:29 UTC 2026
On Fri, 20 Feb 2026 17:41:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> There are some very basic String test cases that came from early CDS development. They don't serve any purposes anymore as the functionalities are already covered by other test cases.
>>
>> The methods of `WhiteBox.{areSharedStringsMapped, isSharedInternedString}` do not work for `AOTStreamedHeapLoader`, whose design doesn't distinguish between strings that came from the CDS archive or the app. The test cases that use these methods don't seem to be worth keeping.
>>
>> `DumpSymbolAndStringTable` should be simplified to only test for `VM.stringtable` and `VM.symboltable`. The boiler-plate tests for `VM.systemdictionary` should be removed as we already have a more elaborate test: `serviceability/dcmd/vm/DictionaryStatsTest.java`.
>
> Good.
Thanks @vnkozlov @matias9927 for the review
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29834#issuecomment-3938007105
More information about the hotspot-dev
mailing list