RFR: 8377658: G1: Cleanup g1ConcurrentMark.cpp for stricter warning flags [v3]

Leo Korinth lkorinth at openjdk.org
Mon Feb 23 12:54:48 UTC 2026


On Fri, 13 Feb 2026 14:11:53 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> In some way, I guess the call sites should be fixed. In other ways I feel that this is a perfect place to stop. By stopping here I can reason using the above assert that `j` is indeed a `u2` (as the type of `bsme->argument_count()` is a u2). If I change the type of `j` I do not know where to stop. I think it would be better with a checked_cast though.
>> 
>> If you want me to continue following the u2 type, you kind of also need to tell me where to stop. After looking at this again, I still come to the conclusion that this is probably a good place to stop.
>
> I'm leaving that decision to you and the maintainers of this code.

I will keep it as is after asking Johan.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29701#discussion_r2840707100


More information about the hotspot-dev mailing list