RFR: 8378470: Add future Intel family number
Volodymyr Paprotski
vpaprotski at openjdk.org
Tue Feb 24 18:43:53 UTC 2026
On Tue, 24 Feb 2026 06:04:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> src/hotspot/cpu/x86/vm_version_x86.hpp line 831:
>>
>>> 829: static int cpu_family() { return _cpu;}
>>> 830: static bool is_P6() { return cpu_family() >= 6; }
>>> 831: static bool is_intel_server_family() { return cpu_family() == 6 || cpu_family() == 18 || cpu_family() == 19; }
>>
>> The "future" processor has a lower number??
>
> Okay I guess I am just somewhat surprised that support for family 19 was added, somewhat quietly, under JDK-8351994 in May last year.
>
> Also from what I have read there is speculation that 19 will be used for the server family while 18 may be used for desktop and mobile! I wonder if we may have to be more explicit about what we mean by "server" in this context and rename it?
> The "future" processor has a lower number??
Annoyingly so, yeah..
> [...] may be used for desktop and mobile! [...]
The name choice.. probably should be revisited. I am struggling for a good alternative though. `is_new_intel_family` would had been good, if 6 was not included.. Maybe just `is_intel_family`? Looking through the callsites.. its only ever called from from `vm_version_x86.cpp` (once from `vm_version_x86.h`) and for the most parts makes sense. I think.
I can go and rename it? Or other name suggestion?
(There is also `is_P6`, but thats another can of worms, that rather not open here.. overlaps, but not the same..)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29852#discussion_r2848928196
More information about the hotspot-dev
mailing list