RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v7]
Ioi Lam
iklam at openjdk.org
Wed Feb 25 11:05:55 UTC 2026
On Tue, 24 Feb 2026 15:50:59 GMT, María Arias de Reyna Domínguez <duke at openjdk.org> wrote:
>> Restored the check `if (resolved)` when printing if a CP entry is rejected or archived. If it is not resolved, we shouldn't even bother with it.
>>
>> Also, added log messages (mostly based on surrounding comments) on `ConstantPoolCache::can_archive_resolved_method` to add information about why a method gets rejected.
>>
>> All the log messages have the same format to be able to parse them easily:
>>
>> ` log.print("%s can't be archived because $REASON.",
>> pool_holder->name()->as_C_string());`
>
> María Arias de Reyna Domínguez has updated the pull request incrementally with one additional commit since the last revision:
>
> fixing compiling errors
Looks good. Just one nit for removing an unused line.
src/hotspot/share/oops/cpCache.cpp line 552:
> 550:
> 551: bool ConstantPoolCache::can_archive_resolved_method(ConstantPool* src_cp, ResolvedMethodEntry* method_entry, const char*& reason) {
> 552: LogStreamHandle(Trace, aot, resolve) log;
This line (552) can be removed.
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29690#pullrequestreview-3851649595
PR Review Comment: https://git.openjdk.org/jdk/pull/29690#discussion_r2850654546
More information about the hotspot-dev
mailing list