RFR: 8302745: sp > unextended_sp for interpreted to interpreted calls going through method handle linker [v2]

Anton Artemov aartemov at openjdk.org
Wed Feb 25 11:08:55 UTC 2026


On Tue, 24 Feb 2026 15:02:19 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8302745: Don't touch ARM code.
>>  - 8302745: Addressed reviewer's comments.
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 353:
> 
>> 351:   // set sender sp
>> 352:   mov(r19_sender_sp, esp);
>> 353:   andr(r19_sender_sp, r19_sender_sp, -16);
> 
> Suggestion:
> 
>   andr(r19_sender_sp, esp, -16);

Addressed.

> src/hotspot/cpu/aarch64/methodHandles_aarch64.cpp line 302:
> 
>> 300:     __ pop(rmember);             // extract last argument
>> 301:     __ mov(r19_sender_sp, esp);  // esp has been moved by 8 bytes, reflect it. The value in r19 will become frame's unextened_sp later on.
>> 302:     __ andr(r19_sender_sp, r19_sender_sp, -16); // Force 16-bytes alignment. It wipes out the 8-byte change made above, but doesn't hurt.
> 
> Same here.

Addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29744#discussion_r2851716465
PR Review Comment: https://git.openjdk.org/jdk/pull/29744#discussion_r2851716621


More information about the hotspot-dev mailing list