RFR: 8378675: PPC64: increase instruction cache line size [v3]
Richard Reingruber
rrich at openjdk.org
Thu Feb 26 16:28:35 UTC 2026
On Thu, 26 Feb 2026 16:24:26 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Doesn't this work as designed? `cpu_microcode_revision()` doesn't have implementations for all platforms, either. The 2 new functions can be implemented on more OSes on demand.
>
> But, your point that the changes in os_aix.hpp and os_linux.hpp are unused declarations is true. I think they should get reverted.
Personally I don't like that. It means you have to check if a method really has a definitions on all platform flavours and versions (OS, libc, ...) before you can use them in shared code. That's just tedious.
And if there's enough laziness in the process of resolving references then only a user might find out that there's no definition for the users platform.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29918#discussion_r2860008826
More information about the hotspot-dev
mailing list