RFR: 8377554: Load card table base and other values via AOTRuntimeConstants in AOT code [v8]

[Andrew Dinn]

On Thu, 26 Feb 2026 19:14:55 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> @vnkozlov Thanks for the review.
>> 
>> @ashu-mehra Any chance of a second review?
>
> @adinn  I just tried to build without CDS and got place where we missed `#if INCLUDE_CDS`:
> 
> +++ b/src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp
> @@ -270,12 +270,13 @@ void G1BarrierSetAssembler::g1_write_barrier_pre(MacroAssembler* masm,
>  }
>  
>  // return a register that differs from reg1, reg2, reg3 and is not rcx
> -
> +#if INCLUDE_CDS
>  static Register pick_different_reg(Register reg1, Register reg2 = noreg, Register reg3= noreg, Register reg4 = noreg) {
>    RegSet available = (RegSet::of(rscratch1, rscratch2, rax, rbx) + rdx -
>                        RegSet::of(reg1, reg2, reg3, reg4));
>    return *(available.begin());
>  }
> +#endif
>  
>  static void generate_post_barrier(MacroAssembler* masm,
> 
> 
> Please apply this update.

@vnkozlov I fixed the CDS build problem. Could you please re-review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29884#issuecomment-3973120534