RFR: 8378793: Add ResolvedFieldEntry is_valid assert [v2]

[David Simms]

On Fri, 27 Feb 2026 13:52:45 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this small change to add an assert for values in ResolvedFieldEntry, which was useful for debugging at one time.
>> Tested with tier1-3
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make assert_is_valid() only debug and only on ResolvedFieldEntry initialization.  Change fill_in to initialize flags also from fieldDescriptor, so set_flags and set_bytecodes can be private.

LGTM. It might feel like overkill, but during Valhalla modifications for get/putfield lead to using a lot of registers, and often bugs were introduced that testing took a really long time to discover compared to "assertion overkill" (they are debug only, basically free).

-------------

Marked as reviewed by dsimms (Author).

PR Review: https://git.openjdk.org/jdk/pull/29943#pullrequestreview-3867172475