RFR: 8374698: Stub names should look more like identifiers [v2]
Andrew Dinn
adinn at openjdk.org
Thu Jan 8 12:04:55 UTC 2026
On Wed, 7 Jan 2026 12:25:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Noticed this when looking at disassembly. Cosmetic issue in [JDK-8360707](https://bugs.openjdk.org/browse/JDK-8360707) makes the stub identifiers look fairly weird:
>>
>>
>> 0x0000786da3c1a6f2: call Stub::Stub Generator lookup_secondary_supers_table_slow_path_stub
>> ; {runtime_call Stub::Stub Generator lookup_secondary_supers_table_slow_path_stub}
>>
>>
>> Notice "Stub Generator" in the middle of the stub identifier.
>>
>> After the fix:
>>
>>
>> 0x00007f357bc1a3f2: call Stub::lookup_secondary_supers_table_slow_path_stub (stub gen)
>> ; {runtime_call Stub::lookup_secondary_supers_table_slow_path_stub (stub gen)}
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Of course there are asserts that verify stub names directly
This is a much more coherent format for the names so thumbs up.
I believe there are a few tests that explicitly check stub names and I cannot recall for sure whether they are all in tier1. Have you tried running the non-tier1 runtime tests? Might well be worth doing before committing.
-------------
Marked as reviewed by adinn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29080#pullrequestreview-3639092283
More information about the hotspot-dev
mailing list