RFR: 8374698: Stub names should look more like identifiers [v2]
Vladimir Kozlov
kvn at openjdk.org
Thu Jan 8 20:52:35 UTC 2026
On Wed, 7 Jan 2026 12:25:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Noticed this when looking at disassembly. Cosmetic issue in [JDK-8360707](https://bugs.openjdk.org/browse/JDK-8360707) makes the stub identifiers look fairly weird:
>>
>>
>> 0x0000786da3c1a6f2: call Stub::Stub Generator lookup_secondary_supers_table_slow_path_stub
>> ; {runtime_call Stub::Stub Generator lookup_secondary_supers_table_slow_path_stub}
>>
>>
>> Notice "Stub Generator" in the middle of the stub identifier.
>>
>> After the fix:
>>
>>
>> 0x00007f357bc1a3f2: call Stub::lookup_secondary_supers_table_slow_path_stub (stub gen)
>> ; {runtime_call Stub::lookup_secondary_supers_table_slow_path_stub (stub gen)}
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Of course there are asserts that verify stub names directly
Looks good to me too.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29080#pullrequestreview-3641254557
More information about the hotspot-dev
mailing list