RFR: 8371014: Dump JFR recording on CrashOnOutOfMemoryError is incorrectly implemented

Robert Toyonaga duke at openjdk.org
Thu Jan 8 21:48:11 UTC 2026


On Wed, 7 Jan 2026 14:14:19 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> Alternative for solving [JDK-8371014](https://bugs.openjdk.org/browse/JDK-8371014)
> 
> Also includes a fix for [JDK-8373257](https://bugs.openjdk.org/browse/JDK-8373257)
> 
> Testing: jdk_jfr, stress testing, manual testing with CrashOnOutOfMemoryError, tier1-6

src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp line 611:

> 609:   if (thread->is_VM_thread()) {
> 610:     const VM_Operation* const operation = VMThread::vm_operation();
> 611:     if (operation != nullptr && operation->type() == VM_Operation::VMOp_JFROldObject) {

Is it better/possible to directly check the rotation lock instead? Maybe it's possible the thread crashed before starting the vm operation, or the lock is held by something else.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29094#discussion_r2674002541


More information about the hotspot-dev mailing list