RFR: 8372245: GTest globalDefinitions.format_specifiers cannot run without VM [v3]
Kim Barrett
kbarrett at openjdk.org
Tue Jan 13 01:37:06 UTC 2026
On Mon, 12 Jan 2026 13:13:19 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> globalDefinitions.format_specifiers uses `ResourceMark` which requires a created VM.
>> Either we stop using resource allocations, or we run the test in VM.
>>
>> I propose we let this test simply use `stringStream::base` rather than `stringStream::as_string` which is an already managed string and the stream is in scope for as long as the string is used. The string is guaranteed to be valid as long as we do not write to the stream.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge branch 'JDK-8372241' into JDK-8372245
> - Merge branch 'JDK-8372241' into JDK-8372245
> - gtest globalDefinitions.format_specifiers cannot run without VM
Why is this PR dependent on https://github.com/openjdk/jdk/pull/28409. If
the change to CheckGtestDependencies.java was removed, this PR could go in
immediately. (And then update https://github.com/openjdk/jdk/pull/28409
accordingly.) I would approve this PR now if that dependency was removed.
-------------
PR Review: https://git.openjdk.org/jdk/pull/28415#pullrequestreview-3653415156
More information about the hotspot-dev
mailing list