RFR: 8373638: RBTree public interface does not check all input parameters for validity [v2]
David Holmes
dholmes at openjdk.org
Tue Jan 13 06:16:47 UTC 2026
On Thu, 8 Jan 2026 10:18:17 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:
>> Hi everyone,
>>
>> The public interface for the `RBTree` assumes most input is valid, and does not check for null pointers. This could lead to potential null pointer dereferences. We should instead assert to give clearer errors in debug builds and to avoid trying to dereference these null pointers.
>>
>> Testing:
>> - Oracle tiers 1-3
>
> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>
> changed asserts to precond
LGTM. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28922#pullrequestreview-3654018181
More information about the hotspot-dev
mailing list