RFR: 8375209: Strengthen Xcheck:jni for JNI critical regions [v3]
David Holmes
dholmes at openjdk.org
Thu Jan 15 22:00:34 UTC 2026
On Thu, 15 Jan 2026 12:02:05 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/hotspot/share/prims/jniCheck.cpp line 218:
>>
>>> 216: tty->print_cr("%s", fatal_other_function_in_critical);
>>> 217: // Ideally the following, but at least AWT code triggers this (ouch!):
>>> 218: // NativeReportJNIFatalError(thr, fatal_other_function_in_critical);
>>
>> So it isn't fatal it is still just a warning.
>
> Yeah, so I am undecided if we want to make it a part this PR: should we turn these warnings into fatal? We can do it separately, since it likely requires fixing the JDK code.
I think warnings are okay here. The JDK code may still need fixing regardless.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29206#discussion_r2696099539
More information about the hotspot-dev
mailing list