RFR: 8372617: Save and restore stubgen stubs when using an AOT code cache [v3]

[Andrew Dinn]

On Tue, 2 Dec 2025 16:46:41 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   asmehra feedback
>
> src/hotspot/share/code/aotCodeCache.cpp line 1742:
> 
>> 1740: // id as an index
>> 1741: 
>> 1742: #define SET_ENTRY_ADDRESS(type, addr, entry_id)           \
> 
> This macro seems to be unused.

Removed

> src/hotspot/share/code/aotCodeCache.cpp line 1975:
> 
>> 1973:     SET_ADDRESS(_extrs, addresses.at(i));
>> 1974:   }
>> 1975:   log_debug(aot, codecache, init)("External addresses recorded");
> 
> This log message is not very helpful. Following the code I now know it refers to the step where arch specific external address are added. So it does seem relevant, however the current message does not convey the context. But I don't know how to improve it either :).

Changed to say "recorded N additional external addresses"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28433#discussion_r2708007200
PR Review Comment: https://git.openjdk.org/jdk/pull/28433#discussion_r2707994166