RFR: 8375534: Debug method 'pp' should support compressed oops [v2]

[Tobias Hartmann]

On Tue, 20 Jan 2026 15:45:03 GMT, Paul Hübner <phubner at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Let's just use print_location instead
>
> src/hotspot/share/utilities/debug.cpp line 426:
> 
>> 424:   }
>> 425: 
>> 426:   if (!Universe::heap()->print_location(tty, p)) {
> 
> FYI, we also have `os::print_location` which adds a few extra goodies (nullcheck + code blob check). Its documentation mentions
>> // moved from debug.cpp (used to be find()) but still called from there
> 
> I'm happy with the current code and I'd also be okay with using the `os` version, I just wanted to point it out in case you think one is more appropriate than the other.

Thanks for taking a look at this. Yes, I've seen that and it's already used by `find` and `findpc`. I think the intention of `pp` is that we already know/expect that the argument is a pointer into the Java heap and therefore want to limit the amount of checks (maybe for performance or stability reasons?) during debugging.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29280#discussion_r2709467784