RFR: 8374519: assert((!inside_attrs()) || VMError::is_error_reported()) failed: cannot print tag inside attrs with "-XX:+LogCompilation -XX:-SerializeVMOutput"

[Guanqiang Han]

On Wed, 21 Jan 2026 03:09:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I do not think this is an issue. There is no guarantee that every combination of flags is valid and useful and won't trip any assertions. If it crashed a product release that would be different - but I tested it and it seemed to work okay.
> 
> There is almost zero reason to ever disable serialized VM output - and arguably we should look at dropping that flag.
> 
> Is xtty only used with LogCompilation, or do we use it for other things?

I agree that -XX:+LogCompilation + -XX:-SerializeVMOutput isn’t a useful combination.

xtty is primarily the xmlStream used for the compilation/CompileLog XML output (i.e., -XX:+LogCompilation). It also has other emission sites in related code paths, and appears to be used by other diagnostics (e.g., TraceDeoptimization, PrintNativeNMethods) as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29337#issuecomment-3776773090