RFR: 8373266: Strengthen constant CardTable base accesses [v2]

[Thomas Schatzl]

On Wed, 21 Jan 2026 13:26:10 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8373266-cardtable-asserts
>>  - Another build fix
>>  - Fix Minimal builds
>>  - Shenandoah non-generational can have nullptr card table
>>  - Also simplify CTBS builder
>>  - CI should also mention "const"
>>  - Fix JVMCI by answering proper things
>>  - Merge branch 'master' into JDK-8373266-cardtable-asserts
>>  - More fixes
>
> src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp line 114:
> 
>> 112:   __ subptr(end, addr); // end --> cards count
>> 113: 
>> 114:   __ mov64(tmp, (intptr_t) ctbs->card_table_base_const());
> 
> Suggestion:
> 
>   __ mov64(tmp, (intptr_t)ctbs->card_table_base_const());

For consistency

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28703#discussion_r2712572480