RFR: 8373266: Strengthen constant CardTable base accesses [v2]
Aleksey Shipilev
shade at openjdk.org
Wed Jan 21 16:41:42 UTC 2026
On Wed, 21 Jan 2026 13:26:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8373266-cardtable-asserts
>> - Another build fix
>> - Fix Minimal builds
>> - Shenandoah non-generational can have nullptr card table
>> - Also simplify CTBS builder
>> - CI should also mention "const"
>> - Fix JVMCI by answering proper things
>> - Merge branch 'master' into JDK-8373266-cardtable-asserts
>> - More fixes
>
> src/hotspot/os_cpu/linux_arm/javaThread_linux_arm.cpp line 47:
>
>> 45: if (bs->is_a(BarrierSet::CardTableBarrierSet)) {
>> 46: CardTableBarrierSet* ctbs = CardTableBarrierSet::barrier_set();
>> 47: _card_table_base = (address) ctbs->card_table_base_const();
>
> Suggestion:
>
> _card_table_base = (address)ctbs->card_table_base_const();
>
> For consistency
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28703#discussion_r2713396310
More information about the hotspot-dev
mailing list