RFR: 8374549: Extend MetaspaceClosure to cover non-MetaspaceObj types

Vladimir Kozlov kvn at openjdk.org
Thu Jan 22 17:37:38 UTC 2026


On Mon, 5 Jan 2026 20:32:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Previously, `MetaspaceClosure` could iterate only `MetaspaceObject`, using its four member functions:
> 
> - `is_read_only_by_default()`
> - `metaspace_pointers_do()`
> - `size()`
> - `type()`
> 
> `PackageEntry`, `ModuleEntry` and `GrowableArray` cannot be subclasses from `MetaspaceObject` due to various constraints.  As a result, they were copied with ad-hoc code.
> 
> This PR updates the templates in `MetaspaceClosure` so that it can iterate any classes  that have the above four functions. This allows new types of data to be uniformly copied into the AOT cache (aka CDS archive) without ad-hoc copiers.
> 
> This PR is necessary for future evolution of AOT as more types of data will be copied into the AOT cache. For example, in Valhalla we have a `GrowableArray` that needs to be copied along with `AdapterHandleEntry`.

src/hotspot/share/cds/cppVtables.cpp line 62:

> 60: 
> 61: // AOTGrowableArray has a vtable only when in non-product builds (due to
> 62: // the virtual printing functions in AnyObj).

Can we devirtualize it? You would need to reconstruct Vpointer in non-debug build otherwise.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29049#discussion_r2717929922


More information about the hotspot-dev mailing list