RFR: 8353564: Fail fatally if os::release_memory or os::uncommit_memory fails [v2]
Stefan Karlsson
stefank at openjdk.org
Fri Jan 23 08:38:42 UTC 2026
On Fri, 23 Jan 2026 08:21:57 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> make memory functions void and remove error strings
>
> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 194:
>
>> 192: // Uncommit...
>> 193: os::uncommit_memory((char*)p, word_size * BytesPerWord, false);
>> 194:
>
> Suggestion:
>
> os::uncommit_memory((char*)p, word_size * BytesPerWord, false);
This is just a removal of a stray extra blank line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29240#discussion_r2720211450
More information about the hotspot-dev
mailing list