Withdrawn: 8367546: Clarify meaning of "corresponding header" for architecture-qualified .inline.hpp files

duke duke at openjdk.org
Tue Jan 27 07:50:22 UTC 2026


On Fri, 12 Sep 2025 13:26:58 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

> During the review of #27189 we stumbled on the lack of a clear indication of what constitutes the `corresponding .hpp` file for a `.inline.hpp` file having an architecture qualifier.
> 
> For example, `continuationHelper_x86.inline.hpp` includes `runtime/continuationHelper.hpp`, and the include statement is on top as stated in the style guide:
> 
> 
> #ifndef CPU_X86_CONTINUATIONHELPER_X86_INLINE_HPP
> #define CPU_X86_CONTINUATIONHELPER_X86_INLINE_HPP
> 
> #include "runtime/continuationHelper.hpp"
> 
> #include "runtime/continuationEntry.inline.hpp"
> #include "runtime/frame.inline.hpp"
> #include "runtime/registerMap.hpp"
> [...]
> 
> 
> However, this order is not respected by `SortIncludes.java`, which does not designate `runtime/continuationHelper.hpp` as the "corresponding `.hpp` file". If this concept was clarified in the style guide, we could improve `SortIncludes` accordingly.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/27259


More information about the hotspot-dev mailing list