RFR: 8371777: Clean up preferred address of G1's archive region
Joel Sikström
jsikstro at openjdk.org
Wed Jan 28 13:08:23 UTC 2026
On Tue, 20 Jan 2026 12:49:05 GMT, Paul Hübner <phubner at openjdk.org> wrote:
> Hi all,
>
> There exists infrastructure in G1 to map the archived region at a certain address, `preferred_addr`. This was however never implemented and abandoned in favour of JEP 516. This is a small cleanup that removes the unused parameter.
>
> Note: the `requested_start` address is still necessary to compute pointer deltas and to perform patching if necessary. If folks feel like `requested` is a misleading name I'm happy to address that as part of a separate RFE.
>
> Testing: tiers 1-5 Linux (x64, AArch64), macOS (x64, AArch64), Windows x64.
Looks good. I think the naming should have been "desired" all the way, not "requested". That way we'd use the "desired" value for the request to allocate the archive region (which we now remove). Sounds good with a follow-up.
-------------
Marked as reviewed by jsikstro (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29317#pullrequestreview-3716603148
More information about the hotspot-dev
mailing list