RFR: 8375038: C2: Enforce that Ideal() returns the root of the subgraph if any change was made by checking the node hash [v2]

Benoît Maillard bmaillard at openjdk.org
Wed Jan 28 17:14:24 UTC 2026


On Tue, 27 Jan 2026 14:22:21 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/opto/node.cpp
>>   
>>   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> src/hotspot/share/opto/node.cpp line 1157:
> 
>> 1155: // can help with validating these invariants, although they are too slow to have on by default:
>> 1156: //    - '-XX:VerifyIterativeGVN=1' checks the def-use info
>> 1157: //    - '-XX:VerifyIterativeGVN=100000' cheks the return value
> 
> Suggestion:
> 
> //    - '-XX:VerifyIterativeGVN=100000' checks the return value

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29421#discussion_r2737660301


More information about the hotspot-dev mailing list