RFR: 8373367: interp-only mechanism fails to work for carrier threads in a corner case [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Jan 30 07:45:07 UTC 2026
On Thu, 29 Jan 2026 23:57:26 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiThreadState.cpp line 61:
>>
>>> 59:
>>> 60: if (JvmtiEnvBase::is_thread_carrying_vthread(thread, thread_oop)) {
>>> 61: // Carrier and virtual threads can temporary share the same JavaThread.
>>
>> Suggestion:
>>
>> // Carrier and virtual threads can temporarily share the same JavaThread.
>
> Also I think this comment block should come before the if statement as it seems to be explaining both the if and else cases.
Thank you for suggestions. Moved and extended the comment to make it more understandable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29436#discussion_r2745036660
More information about the hotspot-dev
mailing list