RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v10]
María Arias de Reyna Domínguez
duke at openjdk.org
Mon Mar 2 08:39:22 UTC 2026
> Restored the check `if (resolved)` when printing if a CP entry is rejected or archived. If it is not resolved, we shouldn't even bother with it.
>
> Also, added log messages (mostly based on surrounding comments) on `ConstantPoolCache::can_archive_resolved_method` to add information about why a method gets rejected.
>
> All the log messages have the same format to be able to parse them easily:
>
> ` log.print("%s can't be archived because $REASON.",
> pool_holder->name()->as_C_string());`
María Arias de Reyna Domínguez has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
- Negative test: make sure nothing is rejected on this test
- Using LogStream
- Update src/hotspot/share/oops/cpCache.cpp
Co-authored-by: Thomas Stuefe <thomas.stuefe at gmail.com>
- Update src/hotspot/share/oops/cpCache.cpp
Co-authored-by: Thomas Stuefe <thomas.stuefe at gmail.com>
- cleanup and fix tests
- fixing compiling errors
- simplify logging and drag reason outside can_archive_resolved_method()
- Reorganize log prints
- Adding index on CPPool for better tracking
- Adding explanation for indy and fields
- ... and 5 more: https://git.openjdk.org/jdk/compare/dc65d0d6...fb5777ce
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29690/files
- new: https://git.openjdk.org/jdk/pull/29690/files/c7124748..fb5777ce
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29690&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29690&range=08-09
Stats: 509372 lines in 1194 files changed: 256807 ins; 242594 del; 9971 mod
Patch: https://git.openjdk.org/jdk/pull/29690.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29690/head:pull/29690
PR: https://git.openjdk.org/jdk/pull/29690
More information about the hotspot-dev
mailing list