RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v10]

Andrew Dinn adinn at openjdk.org
Mon Mar 2 10:25:09 UTC 2026


On Mon, 2 Mar 2026 08:39:22 GMT, María Arias de Reyna Domínguez <duke at openjdk.org> wrote:

>> Restored the check `if (resolved)` when printing if a CP entry is rejected or archived. If it is not resolved, we shouldn't even bother with it.
>> 
>> Also, added log messages (mostly based on surrounding comments) on `ConstantPoolCache::can_archive_resolved_method` to add information about why a method gets rejected.
>> 
>> All the log messages have the same format to be able to parse them easily:
>> 
>> ` log.print("%s can't be archived because $REASON.",
>>                 pool_holder->name()->as_C_string());`
>
> María Arias de Reyna Domínguez has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - Negative test: make sure nothing is rejected on this test
>  - Using LogStream
>  - Update src/hotspot/share/oops/cpCache.cpp
>    
>    Co-authored-by: Thomas Stuefe <thomas.stuefe at gmail.com>
>  - Update src/hotspot/share/oops/cpCache.cpp
>    
>    Co-authored-by: Thomas Stuefe <thomas.stuefe at gmail.com>
>  - cleanup and fix tests
>  - fixing compiling errors
>  - simplify logging and drag reason outside can_archive_resolved_method()
>  - Reorganize log prints
>  - Adding index on CPPool for better tracking
>  - Adding explanation for indy and fields
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/8b805630...fb5777ce

Looks good

-------------

Marked as reviewed by adinn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29690#pullrequestreview-3875252574


More information about the hotspot-dev mailing list