<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
ok.<br>
thanks,<br>
Coleen<br>
<br>
On 11/30/10 16:23, Ivan Krylov wrote:
<blockquote cite="mid:4CF56B56.4050404@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
Coleen,<br>
<br>
I inlined those functions because they were inlined in the hpi files. I
tried to stick to the original code where possible. <br>
<br>
Thanks,<br>
Ivan <br>
<br>
On 11/30/10 9:28 PM, coleen phillimore wrote:
<blockquote cite="mid:4CF54265.3070006@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
Ivan,<br>
This looks good to me. I have some concerns with the inlined socket
functions in:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eikrylov/6348631.v3/src/os/linux/vm/os_linux.inline.hpp.cdiff.html">http://cr.openjdk.java.net/~ikrylov/6348631.v3/src/os/linux/vm/os_linux.inline.hpp.cdiff.html</a><br>
<br>
as it causes the .hpp file to import linux system specific hpp files
which might cause namespace issues down the line. I'd rather these
sorts of includes be in a .cpp file. I don't know if they were inlined
for performance reasons though, but it seems unlikely to have any
benefit.<br>
<br>
Everything else looks great - I like how it removes the #include
hpi.hpp in files that don't even use hpi.<br>
<br>
Thanks,<br>
Coleen<br>
<br>
On 11/30/10 06:54, Ivan Krylov wrote:
<blockquote cite="mid:4CF4E604.8050607@Oracle.COM" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-signature">
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tbody>
<tr>
<td style="padding-top: 6px;" align="left" height="0"
valign="top" width="44"><br>
</td>
</tr>
</tbody>
</table>
</div>
In light of the changes related to the includeDB fix and a few comments
on the previous webrev I am sending a new<br>
request for review<br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eikrylov/6348631.v3/">http://cr.openjdk.java.net/~ikrylov/6348631.v3/</a>
<br>
<br>
On 18.11.2010 10:07, Ivan Krylov wrote:
<blockquote cite="mid:4CE4D0C3.7070609@Oracle.COM" type="cite">With
this fix we are removing the use of the HPI (Host Portable interface)
library from jvm. <br>
<br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eikrylov/6348631/">http://cr.openjdk.java.net/~ikrylov/6348631/</a>
<br>
<br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>