<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Dmitry,<br>
<br>
Do you have any plans to full review and approve this PR?<br>
Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Serguei<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">hotspot-dev <hotspot-dev-retn@openjdk.org> on behalf of Dmitry Samersoff <dmitry.samersoff@bell-sw.com><br>
<b>Date: </b>Friday, October 7, 2022 at 1:34 AM<br>
<b>To: </b>Serguei Spitsyn <sspitsyn@openjdk.org>, hotspot-dev@openjdk.org <hotspot-dev@openjdk.org>, serviceability-dev@openjdk.org <serviceability-dev@openjdk.org><br>
<b>Subject: </b>Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Serguei,<br>
<br>
Looks good for me. Thank you!<br>
<br>
-Dmitry<br>
<br>
On 06/10/2022 20:31, Serguei Spitsyn wrote:<br>
> On Thu, 6 Oct 2022 07:16:44 GMT, Dmitry Samersoff <dsamersoff@openjdk.org> wrote:<br>
> <br>
>>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:<br>
>>><br>
>>> addressed review comments about is_JavaThread_current and @enablePreview tag<br>
>><br>
>> src/hotspot/share/prims/jvmtiEnvBase.hpp line 180:<br>
>><br>
>>> 178: JavaThread* current = JavaThread::current();<br>
>>> 179: oop cur_obj = current->jvmti_vthread();<br>
>>> 180: bool is_current = jt == current && (cur_obj == NULL || cur_obj == thr_obj);<br>
>><br>
>> It might be better to restructure this "if" and check for jt==current before we ask for cur_obj, or at least add brackets.<br>
> <br>
> Thank you for the comment.<br>
> I've refactored it a little bit. Please, let me know if you agree with it.<br>
> <br>
> -------------<br>
> <br>
> PR: <a href="https://git.openjdk.org/jdk/pull/10586">https://git.openjdk.org/jdk/pull/10586</a><br>
<br>
<br>
-- <br>
Dmitry.Samersoff@bell-sw.com<br>
Technical Professional at BellSoft<o:p></o:p></span></p>
</div>
</div>
</body>
</html>