<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div class="moz-cite-prefix">On 12/6/24 3:10 AM, Julian Waters
wrote:<br>
</div>
<blockquote type="cite" cite="mid:tJ3nqrhudfg3Xa5RqnBldlTjyezLwD6YLN4XvnbfrZA=.c8145c45-2a37-4a28-9e91-cffece777d74@github.com">
<pre wrap="" class="moz-quote-pre">On Fri, 6 Dec 2024 06:25:12 GMT, Kim Barrett <a class="moz-txt-link-rfc2396E" href="mailto:kbarrett@openjdk.org"><kbarrett@openjdk.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Please review this change to move the Windows-specific definition of strtok_r
to globalDefinitions_visCPP.hpp. In addition, the unused S_ISCHR macro is
removed and the S_ISFIFO macro is also moved.
Testing: mach5 tier1
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
This moves it to a place inaccessible to my port, but it's a small change and I can handle it rather easily, so I'm ok with this.</pre>
</blockquote>
<p>I suspected that might happen. But this new location seems like
a better place for it than where it was.</p>
<p>I'm assuming you're going to have some non-trivial rearrangement
of things in the globalDefinitions vicinity<span style="white-space: pre-wrap">.
</span></p>
<blockquote type="cite" cite="mid:tJ3nqrhudfg3Xa5RqnBldlTjyezLwD6YLN4XvnbfrZA=.c8145c45-2a37-4a28-9e91-cffece777d74@github.com">
<pre wrap="" class="moz-quote-pre">src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 89:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">87: // under the name strtok_s_l. Make strtok_r a synonym so we can use that name
88: // in shared code.
89: const auto strtok_r = strtok_s;
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Just 1 question, is strtok_r in this VC definition a function pointer?</pre>
</blockquote>
Yes.<br>
<blockquote type="cite" cite="mid:tJ3nqrhudfg3Xa5RqnBldlTjyezLwD6YLN4XvnbfrZA=.c8145c45-2a37-4a28-9e91-cffece777d74@github.com">
<pre wrap="" class="moz-quote-pre"> I don't think I've ever seen code do this before. Also, I think Annex K is C11, not C99</pre>
</blockquote>
Oops. I thought I had C99 open when I was looking at Annex K.<br>
<br>
</body>
</html>