request for review (XXS): 6659981

Y Srinivas Ramakrishna Y.S.Ramakrishna at Sun.COM
Thu Feb 7 18:24:00 UTC 2008


Diffs below: a 1 line change.

Fixed 6659981: VMark Stability Test crash x64 Solaris 64 bit 6.0 VM

When +ParallelRefProcEnabled is specified either on a single core
platform or prset, or  ParallelGCThreads=0 is explicitly specified,
the reference processor was assuming that it would have the requisite number
of parallel workers (of which there are none) to get the job done.

Fix verified: yes

Verification testing: specjvm98 with all collectors with +ParallelRefProcEnabled
  and running either or MP or 1-core platform with ParallelGCThreads set to {0,1, 2}.


------- referenceProcessor.cpp -------

*** /tmp/sccs.MraOvL    Thu Feb  7 09:56:18 2008
--- referenceProcessor.cpp      Thu Feb  7 09:52:34 2008
***************
*** 85,91 ****
    ReferenceProcessor* rp =
      new ReferenceProcessor(span, atomic_discovery,
                             mt_discovery, mt_degree,
!                            mt_processing);
    if (rp == NULL) {
      vm_exit_during_initialization("Could not allocate ReferenceProcessor object");
    }
--- 85,91 ----
    ReferenceProcessor* rp =
      new ReferenceProcessor(span, atomic_discovery,
                             mt_discovery, mt_degree,
!                            mt_processing && parallel_gc_threads > 0);
    if (rp == NULL) {
      vm_exit_during_initialization("Could not allocate ReferenceProcessor object");
    }




More information about the hotspot-gc-dev mailing list