request for review (medium): 6722113

John Coomes John.Coomes at sun.com
Thu Nov 20 01:58:02 UTC 2008


Y Srinivas Ramakrishna (Y.S.Ramakrishna at Sun.COM) wrote:
> 
> 6722113 CMS: Incorrect overflow handling during precleaning of Reference lists
> 
>      http://bugs.sun.com/view_bug.do?bug_id=6722113
> 
>      webrev: http://webrev.invokedynamic.info/ysr/6722113/
> ...

Looks good to me.  One nit:  instead of adding a friend decl to
CMSKeepAliveClosure, I think it'd be better to add a public accessor
for the _concurrent_precleaning boolean and have
CMSDrainMarkingStackClosure use that.

-John




More information about the hotspot-gc-dev mailing list