CRR: 6882730: G1: parallel heap verification messes up region dump

Tony Printezis tony.printezis at sun.com
Fri Oct 2 20:57:51 UTC 2009


Thanks to John Cuthbertson for the code review. I have a new webrev that 
includes a small fix that John recommended:

http://cr.openjdk.java.net/~tonyp/6882730/webrev.1/

I'd like one more code review if possible. Thanks!

Tony

Tony Printezis wrote:
> The webrev is here:
>
> http://cr.openjdk.java.net/~tonyp/6882730/webrev.0/
>
> In the fix, I just propagate the fact that heap verification failed 
> all the way to the top-level ::verify call and dump the heap there, 
> where it is guaranteed to be single-threaded. I also added a couple of 
> cosmetic changes to the heap dump.
>
> Tony
>

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)





More information about the hotspot-gc-dev mailing list