CRR: 6888316 and 6888619 (remove guarantees / change guarantees to asserts in concurrent mark) (S)

Igor Veresov Igor.Veresov at Sun.COM
Wed Oct 7 03:42:22 UTC 2009


Looks good.

igor

On 10/6/09 2:31 PM, Tony Printezis wrote:
> Hi all,
>
> Could I please get a couple of code reviews for this one?
>
> http://cr.openjdk.java.net/~tonyp/6888316/webrev.0/
>
> The important (and very small) change is the removal of a guarantee that
> is incorrect. Please have a look at the Evaluation notes on CR 6888316
> for details.
>
> The less important (but larger) change is the change of many guarantees
> in the G1 concurrent marking code into asserts (as we should not have
> that overhead in the product build). I also took this opportunity to
> split some of the asserts and tidy up formatting.
>
> There are about 150 lines changed, but the changes are straightforward,
> even though somewhat tedious to review.
>
> Thanks,
>
> Tony
>




More information about the hotspot-gc-dev mailing list