review request (S): 6966222: G1: simplify TaskQueue overflow handling
Y. Srinivas Ramakrishna
y.s.ramakrishna at oracle.com
Tue Aug 3 23:48:51 UTC 2010
Also looks good.
-- ramki
John Coomes wrote:
> I (John.Coomes at oracle.com) wrote:
>> I'd appreciate reviews of the changes to simplify TaskQueue overflow
>> handling in G1.
>>
>> http://cr.openjdk.java.net/~jcoomes/6966222-taskqueue-g1/
>
> I updated the webrev; the main difference is to format the output as a
> table. See the webrev comments for more details.
>
> I'd particularly like people to verify that the change in the duration
> that the stats_lock() is held is correct (g1CollectedHeap.cpp).
>
>> The changes are limited to 2 files, and more lines were deleted than
>> added :-).
>
> Unfortunately, the above two statements are no longer accurate :-(.
>
> -John
>
More information about the hotspot-gc-dev
mailing list