CRR: 7027766: G1: introduce flag to dump the liveness information per region at the end of marking (S)

[Jesper Wilhelmsson]

Hmm, ok. If we find that we want to use it in some other collector we can always move it to a more generic package at that point.

Btw, if everyone has agreed on the format by now, the actual change looks fine.
Ship it!
/Jesper

1 apr 2011 kl. 14:48 skrev Tony Printezis <tony.printezis at oracle.com>:

> Jesper,
> 
> Not quite sure what you mean by "introducing new functionality" here. I introduced the formatting macros to keep the output of this flag consistent and to be able to easily change it uniformly. The macros basically specify things like "a size column will be 10 characters long, it will have to spaces before it, and make sure you format its header the same way". They are prefixed with G1 to avoid name clashes. I don't think this is something applicable anywhere else.
> 
> Tony
> 
> On 4/1/2011 7:44 AM, Jesper Wilhelmsson wrote:
>> Tony,
>> 
>> Why are the new formatting macros G1 specific?  Wouldn't it be better to have a generic set of formatting macros that we can use all over the GC code?
>> 
>> I'm not saying we should change the rest of the GC code to use these macros right now, but since you are introducing new functionality I think it would be nice if that functionality could be used by all GCs.
>> /Jesper
>> 
>> 
>> On 03/25/2011 06:20 PM, Tony Printezis wrote:
>>> Hi,
>>> 
>>> I'd like a couple of reviewers to have a look at this change:
>>> 
>>> http://cr.openjdk.java.net/~tonyp/7027766/webrev.0/
>>> 
>>> I ended up repurposing the existing develop flag G1PrintRegionLivenessInfo for
>>> this (I had actually forgotten it was there!) and I print the liveness
>>> information at the end of marking twice:
>>> 
>>> - Info for all regions after we finalize the marking information, which means
>>> we have both the latest marking information as well as the previous marking
>>> information available.
>>> - The same info but for all sorted old regions.
>>> 
>>> I attached example output.
>>> 
>>> Tony