Request for review (XS): 7036482: clear argument is redundant and unused in cardtable methods

Y. Srinivas Ramakrishna y.s.ramakrishna at oracle.com
Thu Apr 14 08:22:19 UTC 2011


Thanks for the review Bengt.

On 4/14/2011 12:42 AM, Bengt Rutisson wrote:
>
> Ramki,
>
> Looks good.
>
> One question:
>
> In allocationStats.hpp your only change is a style issue that is not really related to removing the
> clear argument. Is it intentional to include this in the change? (I agree that it looks better the
> way you do it.)

I could either sneak it in here without further ado, or drop it. I'll let you and John vote :-)

>
>
> Also, copyright year...

I'll fix that; thanks!

-- ramki


>
> Bengt
>
>
> On 2011-04-14 02:42, Y. S. Ramakrishna wrote:
>>
>> 7036482: clear argument is redundant and unused in cardtable methods
>>
>> http://cr.openjdk.java.net/~ysr/7036482/webrev.00/
>>
>> As in synopsis; further motivational detail may be found
>> in the CR. Some further cleanups/deletions will follow in
>> subsequent CR's to be filed.
>>
>> thanks for your reviews.
>> -- ramki
>




More information about the hotspot-gc-dev mailing list