RFR(M): 7004681: G1: Extend marking verification to marking phase of Full GCs

John Cuthbertson john.cuthbertson at oracle.com
Thu Apr 28 17:59:59 UTC 2011


Hi All,

Another new webrev for this CR can be found at: 
http://cr.openjdk.java.net/~johnc/MarkSweep-VerifyMark/webrev.5/

The changes since the last one are just a reconciliation, in 
g1CollectedHeap.cpp, between the previous changes and Ramki's changes 
for 7039089.

Testing: I ran the GC test suite overnight with VerifyDuringGC and a low 
initial occupancy threadhold (5%)

Thanks,

JohnC

On 04/26/11 12:01, John Cuthbertson wrote:
> Hi All,
>
> A new webrev is here: 
> http://cr.openjdk.java.net/~johnc/MarkSweep-VerifyMark/webrev.4/
>
> The changes made since the last webrev include a suggestion from Tony 
> to fold the check from G1CollectedHeap::checkConcurrentMark into the 
> VerifyObjsInRegionClosure and remove the checkConcurrentMark routine 
> and associated closure.
>
> Thanks,
>
> JohnC
>
> On 04/22/11 17:33, John Cuthbertson wrote:
>> Hi Everyone,
>>
>> A new webrev for this CR can be found at: 
>> http://cr.openjdk.java.net/~johnc/MarkSweep-VerifyMark/webrev.3.
>>
>> I'd like to get at least another person look over these changes (Tony 
>> has already looked at an earlier version). The latest webrev includes 
>> skipping the region set verification if the verification was called 
>> from a full GC (in G1 the region sets are torn down at the start of 
>> the full GC and so the verification will give a false failure).
>>
>> Testing: GC test suite with +VerifyDuringGC with and without G1.
>>
>> Thanks,
>>
>> JohnC
>




More information about the hotspot-gc-dev mailing list