Request for review: 6941923: RFE: Handling large log files produced by long running Java Applications

[Jesper Wilhelmsson]

Yumin,

In ostream.hpp lines 199 - 215 you have added a block of code that is 
commented out. Personally I don't think we should have code that is commented 
out in there unless there is a good documentation reason for it. I don't see 
such a reason here.

Looks good otherwise.
/Jesper



On 04/28/2011 11:18 PM, yumin.qi at oracle.com wrote:
> Hi,
>
> Need your review on the second time changes:
>
> http://cr.openjdk.java.net/~minqi/6941923/webrev.01
>
> Any comments on the revised version? thanks in advance.
>
> Yumin
>