review(S): 7124829: NUMA: memory leak on Linux with large pages

[Igor Veresov]

Thank you!  

igor


On Tuesday, December 27, 2011 at 3:21 PM, Vladimir Kozlov wrote:

> Looks good.
>  
> Thanks,
> Vladimir
>  
> Igor Veresov wrote:
> > Right, thanks! I've updated the webrev.
> >  
> > igor
> >  
> > On Tuesday, December 27, 2011 at 10:40 AM, Vladimir Kozlov wrote:
> >  
> > > You missed changes (additional parameter) in other OS files: bsd, solaris.
> > >  
> > > Vladimir
> > >  
> > > Igor Veresov wrote:
> > > > The issue is with os::free_memory() changes made in 7060842 when the
> > > > “madvise” call was replaced with “mmap”. This is the reason of
> > > > exhaustive memory consumption. Seems when we need to remap some memory
> > > > we need to do it using the same flags as we mapped it initially,
> > > > particularly with “MAP_HUGETLB”. Otherwise system maps small pages
> > > > instead of already reserved huge pages.
> > > >  
> > > > Contributed by: Aleksey Ignatenko <aleksey.v.ignatenko at intel.com (mailto:aleksey.v.ignatenko at intel.com)  
> > > > <mailto:aleksey.v.ignatenko at intel.com>>
> > > >  
> > > > Webrev: http://cr.openjdk.java.net/~iveresov/7124829/webrev.00/
> > > >  
> > > > igor  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20111227/60c5ba34/attachment.htm>